SQL: [Tests] Re-enable testDriverConfigurationWithSSLInURL test with more logging#44800
Merged
astefan merged 4 commits intoelastic:masterfrom Jul 25, 2019
Merged
Conversation
additional logging from the DriverManager.
Collaborator
|
Pinging @elastic/es-search |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/2 |
matriv
approved these changes
Jul 24, 2019
| @AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/41557") | ||
| public void testDriverConfigurationWithSSLInURL() { | ||
| @SuppressForbidden(reason = "JDBC drivers allows logging to Sys.out") | ||
| public void testDriverConfigurationWithSSLInURL() throws Exception { |
Contributor
There was a problem hiding this comment.
I think throws Exception is not necessary.
matriv
changed the title
…o enable_jdbc_driver_ssl_test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #41557, this PR re-enables
JdbcConfigurationTests.testDriverConfigurationWithSSLInURLwith more logging coming from the DriverManager hopefully getting more insight for the next time this test fails.